On 19.08.25 16:45, Heinrich Schuchardt wrote: > On 19.08.25 16:33, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> This is needed because distro_efi_read_bootflow_net will then need >> dhcp_run which is not already enabled by CMD_NET. >> >> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> >> --- >> lib/efi_loader/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig >> index c2aa88f59fb..a4055e1cb43 100644 >> --- a/lib/efi_loader/Kconfig >> +++ b/lib/efi_loader/Kconfig >> @@ -564,6 +564,7 @@ config EFI_HTTP_BOOT >> bool "EFI HTTP Boot support" >> depends on NET || NET_LWIP >> select CMD_NET >> + select CMD_DHCP > > It would be preferable to get rid of all CMD_* symbols here. They are > just the result of missing separation of CLI and library. > > DHCP is not needed to boot via HTTP. You can manually set up a network > interface.
As I wrote, we need it in order to even compile U-Boot. Should we rather wrap some bits with #if defined(CONFIG_CMD_DHCP)? Then tell me, which ones. > > Please, change your patch to use "implies". That would allow to disable CMD_DHCP again, resulting in a non-compilable configuration. Jan -- Siemens AG, Foundational Technologies Linux Expert Center
