On Fri, Aug 29, 2025 at 04:58:07AM +0000, Chee, Tien Fong wrote: > > > > -----Original Message----- > > From: Ravulapalli, Naresh Kumar <naresh.kumar.ravulapa...@altera.com> > > Sent: Thursday, August 28, 2025 9:52 PM > > To: u-boot@lists.denx.de > > Cc: Marek Vasut <marek.va...@mailbox.org>; Simon Goldschmidt > > <simon.k.r.goldschm...@gmail.com>; Chee, Tien Fong > > <tien.fong.c...@altera.com>; Tom Rini <tr...@konsulko.com>; Ravulapalli, > > Naresh Kumar <naresh.kumar.ravulapa...@altera.com> > > Subject: [PATCH v2] drivers: clk: agilex: Correct EMAC clock source > > selection > > > > Fix the incorrect bit masking and bit shift used to compute EMAC control > > which in turn is used to select EMAC clock from EMAC source A or B. > > > > Signed-off-by: Naresh Kumar Ravulapalli > > <nareshkumar.ravulapa...@altera.com> > > --- > > drivers/clk/altera/clk-agilex.c | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/clk/altera/clk-agilex.c > > b/drivers/clk/altera/clk-agilex.c > > index e1ddd02f356..2ad8cfd8856 100644 > > --- a/drivers/clk/altera/clk-agilex.c > > +++ b/drivers/clk/altera/clk-agilex.c > > @@ -1,6 +1,7 @@ > > -// SPDX-License-Identifier: GPL-2.0 > > +// SPDX-License-Identifier: GPL-2.0+ > > /* > > * Copyright (C) 2019 Intel Corporation <www.intel.com> > > + * Copyright (C) 2025 Altera Corporation <www.altera.com> > > */ > > > > #include <log.h>
This is a NAK here. You can't just change the license, especially without calling it out in the commit message. And I'm not pleased with "make a small change, add/extend copyright". I'm not going to run around NAK'ing everything else you've sent but I'm going to ask you to stop doing that for changes that are not significant in size or scope. -- Tom
signature.asc
Description: PGP signature
