On Mon, Oct 06, 2025 at 05:54:08PM +0200, Kory Maincent wrote: > On Mon, 6 Oct 2025 09:33:28 -0600 > Tom Rini <[email protected]> wrote: > > > On Mon, Oct 06, 2025 at 05:22:24PM +0200, Kory Maincent wrote: > > > On Mon, 6 Oct 2025 17:13:35 +0200 > > > Kory Maincent <[email protected]> wrote: > > > > > > > On Mon, 18 Aug 2025 10:54:06 -0600 > > > > Tom Rini <[email protected]> wrote: > > > > > > [...] > > > > > > > > This broke the build of sandbox_defconfig: > > > > > > It seems CONFIG_SANDBOX_SDL=y is missing in every sandbox defconfig, and > > > it > > > is required to have CONFIG_VIDEO_SANDBOX_SDL enabled. > > > > How we detect SDL is kind of odd and could be improved. I suspect that > > VIDEO_SANDBOX_SDL needs to 'depends on SANDBOX_SDL' as part of the > > solution too. > > Oh indeed didn't know it was a dynamic check. > > So the issue is not SANDBOX_SDL missing but rather not compile expo and cedit > boot tests if SDL is not available: > > diff --git a/test/boot/Makefile b/test/boot/Makefile > index 00223b44fe0..89538d4f0a6 100644 > --- a/test/boot/Makefile > +++ b/test/boot/Makefile > @@ -6,9 +6,11 @@ ifdef CONFIG_UT_BOOTSTD > obj-$(CONFIG_BOOTSTD) += bootdev.o bootstd_common.o bootflow.o bootmeth.o > obj-$(CONFIG_FIT) += image.o > > +ifdef CONFIG_VIDEO_SANDBOX_SDL > obj-$(CONFIG_EXPO) += expo.o > obj-$(CONFIG_CEDIT) += cedit.o > endif > +endif
Looks good, please make a proper patch, thanks! -- Tom
signature.asc
Description: PGP signature
