Hi Peng,
Thank you for your feedback.
On 10/23/2025 12:38 PM, Peng Fan wrote:
Hi Tanmay,
Subject: [PATCH] mmc: sdhci: Add SDHCI_SPEC_400, _410, and _420
version defines
Add SDHCI_SPEC_400, SDHCI_SPEC_410, and SDHCI_SPEC_420 macros
to sdhci.h to support newer SDHCI specification versions. These defines
are required for compatibility with controllers implementing SDHCI 4.0
and above.
Signed-off-by: Tanmay Kathpalia <[email protected]>
---
include/sdhci.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/sdhci.h b/include/sdhci.h index
2372697b743..a962cc93caa 100644
--- a/include/sdhci.h
+++ b/include/sdhci.h
@@ -223,6 +223,9 @@
#define SDHCI_SPEC_100 0
#define SDHCI_SPEC_200 1
#define SDHCI_SPEC_300 2
+#define SDHCI_SPEC_400 3
+#define SDHCI_SPEC_410 4
+#define SDHCI_SPEC_420 5
Let's add them when there are real users of these macros.
Thanks,
Peng.
I am currently working on another patch series related to SDHCI Cadence,
which will require the use of these newer SDHCI specification version
macros. Would you prefer that I add these defines as part of that
upcoming series, instead of as a standalone patch?
I initially thought of submitting these changes separately since they
affect the SDHCI interface file and could be useful for future SDHCI
controller support, but I’m happy to include them in the series if
that’s preferable.
Please let me know your preference.
Thanks,
Tanmay
