On 10/15/25 2:43 AM, Weijie Gao wrote:

Hello everyone,

-#if defined(CONFIG_PHY_AQUANTIA_UPLOAD_FW)
-static int aquantia_read_fw(u8 **fw_addr, size_t *fw_length)

I think it's better to add a weak function, e.g.:
int __weak aquantia_read_fw(u8 **fw_addr, size_t *fw_length);

And put the default fw loading logic into this function.
Overriding this function by board allows using firmware data embedded
into u-boot by binman.

It's useful in case that firmware data was damaged in filesystem.
Is the firmware GPL that is embedded into U-Boot GPL too ?

Be mindful of the licensing implications here.

Reply via email to