On 10/31/25 6:21 PM, Beiyan Yun wrote:


On 31 Oct 2025, at 11:51 PM, Marek Vasut <[email protected]> wrote:

On 10/31/25 4:21 PM, Beiyan Yun wrote:
Refresh format using clang-format.
Signed-off-by: Beiyan Yun <[email protected]>
---
Changes in v4:
- New
  drivers/net/phy/aquantia.c | 159 +++++++++++++++++--------------------
  1 file changed, 75 insertions(+), 84 deletions(-)
diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c
index 903fcd667f6..439c4c48bdc 100644
--- a/drivers/net/phy/aquantia.c
+++ b/drivers/net/phy/aquantia.c
@@ -18,28 +18,28 @@
  #include <asm/byteorder.h>
  #include <fs.h>
  -#define AQUNTIA_10G_CTL              0x20
-#define AQUNTIA_VENDOR_P1      0xc400
+#define AQUNTIA_10G_CTL 0x20
+#define AQUNTIA_VENDOR_P1 0xc400
  -#define AQUNTIA_SPEED_LSB_MASK       0x2000
-#define AQUNTIA_SPEED_MSB_MASK 0x40
+#define AQUNTIA_SPEED_LSB_MASK 0x2000
+#define AQUNTIA_SPEED_MSB_MASK 0x40
#define<space>MACRO<tab>0xvalue

is perfectly fine format.

Agree, until clang-format has become the default.
This change makes readability worse, no matter what formatting tool is the current recommendation.

Reply via email to