Re: [PATCH 1/2] configs: Add rock5b_plus-rk3588_defconfig

[Tom Rini]

On Tue, Nov 04, 2025 at 12:25:11PM -0600, Bryan Hinton wrote:
> Add initial defconfig for the Radxa ROCK 5B+ (RK3588), tested on board
> revision 1.2 with 32 GB LPDDR5. This mirrors the existing ROCK 5B baseline
> and uses the DTS from U-Boot’s vendored Linux snapshot
> (rockchip/rk3588-rock-5b-plus).
> 
> Build and test details:
>   - U-Boot build: 2026.01-rc1-00232-g0673831a738b-dirty (Nov 04 2025 - 
> 21:18:07 -0600)
>   - Toolchain: aarch64-linux-gnu-gcc (GCC) 15.1.0
>   - DDR TPL: rkbin/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
>   - BL31: rkbin/bin/rk35/rk3588_bl31_v1.51.elf
>   - Boot medium: microSD card (U-Boot image written via dd)
>   - SoC: RK3588 (8× Cortex-A76/A55)
>   - DRAM: 32 GiB LPDDR5 detected
>   - eMMC socket present but module not soldered (controller still detected)
>   - Verified: SPL → U-Boot prompt
>   - `mmc list` shows SD + eMMC controllers
>   - USB EHCI/XHCI enumeration works (`usb tree`)
>   - Control FDT present (`fdt addr ${fdtcontroladdr}; fdt print / model`)
>   - Default environment: `fdtfile=rockchip/rk3588-rock-5b-plus.dtb`
> 
> This configuration reuses the ROCK 5B base defconfig with minimal adjustments
> and builds from the upstream DTS snapshot. Follow-up patches will enable
> NVMe, Ethernet, and saveenv support.
> 
> Signed-off-by: Bryan Hinton <br...@bryanhinton.com>
> ---
>  configs/rock5b_plus-rk3588_defconfig | 118 +++++++++++++++++++++++++++
>  1 file changed, 118 insertions(+)
>  create mode 100644 configs/rock5b_plus-rk3588_defconfig

A thing we don't talk about enough is that defconfig files can use
"#include". So how much is different here from
configs/rock5b-rk3588_defconfig and could we instead do something like
configs/rpi_4_acpi_defconfig does to just augment an existing defconfig?
Next, this needs to update a MAINTAINERS file at the same time in order
for CI to pass.

[snip]
> +# Minimal first version; follow-ups can add NVMe, Ethernet, saveenv
> +# CONFIG_CMD_SAVEENV is not set
> +# CONFIG_NVME is not set

Please don't include that, and make sure this is the output from a "make
savedefconfig" so that we don't have noise in the file later when it's
resynced automatically. Thanks!

-- 
Tom

signature.asc
Description: PGP signature