Hi On Fri, Nov 7, 2025 at 11:56 AM Eugen Hristev <[email protected]> wrote: > > > > On 11/6/25 13:12, Zixun LI wrote: > > "timing" is unused in atmel_pmecc struct, also it's not exist in Linux > > driver, let's remove it. > > > > Signed-off-by: Zixun LI <[email protected]> > > --- > > drivers/mtd/nand/raw/atmel/pmecc.c | 2 -- > > drivers/mtd/nand/raw/atmel/pmecc.h | 1 - > > 2 files changed, 3 deletions(-) > > > > diff --git a/drivers/mtd/nand/raw/atmel/pmecc.c > > b/drivers/mtd/nand/raw/atmel/pmecc.c > > index > > 7c4e9bd5f9967b119239adf2b39e683ea62b71fd..8fc5614cc0091d3e0f4b9280beee9e684fe2a57d > > 100644 > > --- a/drivers/mtd/nand/raw/atmel/pmecc.c > > +++ b/drivers/mtd/nand/raw/atmel/pmecc.c > > @@ -839,8 +839,6 @@ atmel_pmecc_create(struct udevice *dev, > > ofnode_read_resource(dev->node_, 1, &res); > > pmecc->regs.errloc = (void *)res.start; > > > > - pmecc->regs.timing = 0; > > - > > I see there is also an unused parameter to atmel_pmecc_create() called > timing_res_idx . > Maybe this parameter was intended to be passed to the timing mapped memory ? > > If the timing_res_idx is related and unused as well, isn't it supposed > to be removed together ? > > I see it's being called with a hardcoded "2" , does this have any > significance that you know of ? Or it can be safely removed. > > Eugen > > > /* pmecc data setup time */ > > if (caps->clk_ctrl) > > writel(PMECC_CLK_133MHZ, pmecc->regs.base + ATMEL_PMECC_CLK); > > diff --git a/drivers/mtd/nand/raw/atmel/pmecc.h > > b/drivers/mtd/nand/raw/atmel/pmecc.h > > index > > 43f96b2f168c7b88e0c907996f2ae64f8554ed58..88b0d18040e7c48f226c74ce9b5caf93b5760360 > > 100644 > > --- a/drivers/mtd/nand/raw/atmel/pmecc.h > > +++ b/drivers/mtd/nand/raw/atmel/pmecc.h > > @@ -65,7 +65,6 @@ struct atmel_pmecc { > > struct { > > void __iomem *base; > > void __iomem *errloc; > > - void __iomem *timing; > > } regs; > > > > /* Mutex used for pmecc enable/disable */ > > > I'm willing to help to clock part of nand, can someone point where I can buy the board?
Michael -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
