On Fri, 7 Nov 2025 at 01:28, Tom Rini <[email protected]> wrote: > > When building with clang, we see a warning: > lib/efi_selftest/efi_selftest_snp.c:63:18: error: field dhcp_hdr within > 'struct dhcp' is less aligned than 'struct dhcp_hdr' and is usually due > to 'struct dhcp' being packed, which can lead to unaligned accesses > [-Werror,-Wunaligned-access] > when building lib/efi_selftest/efi_selftest_snp.c. Resolve this error by > packing struct dhcp_hdr as well, as the only place it is used also is > packed. > > Signed-off-by: Tom Rini <[email protected]>
Reviewed-by: Ilias Apalodimas <[email protected]> > --- > Cc: Heinrich Schuchardt <[email protected]> > Cc: Ilias Apalodimas <[email protected]> > Cc: Adriano Cordova <[email protected]> > --- > lib/efi_selftest/efi_selftest_snp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_selftest/efi_selftest_snp.c > b/lib/efi_selftest/efi_selftest_snp.c > index b00c76c2f172..290ed3a28f2c 100644 > --- a/lib/efi_selftest/efi_selftest_snp.c > +++ b/lib/efi_selftest/efi_selftest_snp.c > @@ -43,7 +43,7 @@ struct dhcp_hdr { > u8 chaddr[16]; > u8 sname[64]; > u8 file[128]; > -}; > +} __packed; > > /* > * Message type option. > -- > 2.43.0 >
