On Fri, 14 Nov 2025 at 07:43, Tom Rini <[email protected]> wrote: > > On Fri, Nov 14, 2025 at 07:24:53AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 14 Nov 2025 at 07:19, Tom Rini <[email protected]> wrote: > > > > > > On Fri, Nov 14, 2025 at 05:31:40AM -0700, Simon Glass wrote: > > > > Hi Heinrich, > > > > > > > > On Sun, 9 Nov 2025 at 03:10, Heinrich Schuchardt > > > > <[email protected]> wrote: > > > > > > > > > > The location of memory depends on the board. Do not assume memory at > > > > > fixed > > > > > memory locations. Use memalign() instead to allocate a buffer. > > > > > > > > > > Signed-off-by: Heinrich Schuchardt <[email protected]> > > > [snip] > > > > > /* bytes */ > > > > > print_hex_dump_bytes("", DUMP_PREFIX_ADDRESS, buf, 0x12); > > > > > ut_assert_nextline("%0*lx: 00 11 22 33 44 55 66 77 88 99 aa > > > > > bb cc dd ee ff ..\"3DUfw........", > > > > > - IS_ENABLED(CONFIG_PHYS_64BIT) ? 16 : 8, > > > > > - (uintptr_t)buf); > > > > > + IS_ENABLED(CONFIG_PHYS_64BIT) ? 16 : 8, > > > > > addr); > > > [snip] > > > > This is adding memory allocations to a test for hex dumping. > > > > > > > > It would be better and simpler to use a fixed address and make this a > > > > sandbox-only test. I struggle to see the value of running these sorts > > > > of tests under QEMU? > > > > > > Removing context to highlight value of running tests on multiple > > > platforms. > > > > $ ./tools/qconfig.py -f ~PHYS_64BIT -l |grep sandbox > > sandbox > > sandbox_flattree > > sandbox_nocmdline > > sandbox_noinst > > sandbox_spl > > sandbox_vpl > > $ ./tools/qconfig.py -f PHYS_64BIT -l |grep sandbox > > sandbox64 > > sandbox64_lwip
If at any point you have made up your mind, please say so, rather than continuing what I intended to be a discussion of the pros and cons of this patch. > Good, and as soon as you restrict to "sandbox" we stop running > "sandbox64", it's why sandbox64 runs so much quicker in CI. This is a C test - test/cmd/fdt.c so it is built for all sandbox boards. The restriction you are referring to here is for pytests, I believe. The core of my argument is that running sandbox tests on other architectures is mostly a waste of time, assuming the compiler is functioning correctly. This patch is also devaluing sandbox, the major advantages of which is its fast, native code execution and fixed execution environment (memory map, etc.). At the very least, it would help to be clear what bugs we are hoping to find with this change. - Simon
