On Tue, Nov 18, 2025 at 04:10:24PM +0100, Markus Schneider-Pargmann wrote: > Hi Tom, > > On Tue Nov 18, 2025 at 3:02 PM CET, Tom Rini wrote: > > On Tue, Nov 18, 2025 at 11:40:23AM +0100, Markus Schneider-Pargmann > > (TI.com) wrote: > > > >> clk/ti/clk.c is compiled when ARCH_OMAP2PLUS is set and uses regmap > >> functions. Add REGMAP dependency to prevent linking errors when CLK_TI_* > >> options are enabled. > >> > >> Signed-off-by: Markus Schneider-Pargmann (TI.com) <[email protected]> > >> --- > >> arch/arm/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >> index > >> 3db5474a05b8c08e111e8c8b98c3a6fe68de15f2..c72821ce2131e9d9deebef4fce3757fc68bd9f3f > >> 100644 > >> --- a/arch/arm/Kconfig > >> +++ b/arch/arm/Kconfig > >> @@ -844,6 +844,7 @@ config ARCH_OMAP2PLUS > >> bool "TI OMAP2+" > >> select CPU_V7A > >> select GPIO_EXTRA_HEADER > >> + select REGMAP > >> select SPL_SOC_INIT if SPL > >> select SPL_STACK_R if SPL > >> select SUPPORT_SPL > > > > This belongs with the appropriate CLK entry, and Yegor Yefremov has been > > fixing some issues along these lines recently as well. > > Yes, that's what I wanted to do, but the functions that use regmap are > compiled if ARCH_OMAP2PLUS is selected. From drivers/clk/ti/Makefile: > > obj-$(CONFIG_ARCH_OMAP2PLUS) += clk.o omap4-cm.o > > clk.c is where the required functions are implemented.
That should probably be fixed to if nothing else have its own symbol under drivers/clk/ti/Kconfig then, if there's not already a good symbol to be using for them. -- Tom
signature.asc
Description: PGP signature
