Hi David, Thank you for the series
On Wed, Dec 17, 2025 at 12:42, David Lechner <[email protected]> wrote: > While trying to run the test suite for the first time, I encountered a > few minor issues. Here are a few patches to address them. > > --- > Changes in v2: > - Dropped patch adding setuptools to test/py/requirements.txt > - New patch to add setuptools to scripts/dtc/pylibfdt/requirements.txt > instead. > - Changed test.py patch to set ubconfig to None rather than checking for > its existence in globals(). > - Link to v1: > https://lore.kernel.org/r/20251121-a-few-test-py-improvements-v1-0-bacb4148f...@baylibre.com Tested on a fresh fedora container with: $ python -m venv venv $ source venv/bin/activate $ pip install -r test/py/requirements.txt $ pip install -r scripts/dtc/pylibfdt/requirements.txt Then I could build and test with: $ ./test/py/test.py --bd sandbox --build -k ut Tested-by: Mattijs Korpershoek <[email protected]> # sandbox Also, all patches look good to me, so: Reviewed-by: Mattijs Korpershoek <[email protected]> > > --- > David Lechner (3): > test.py: check ubconfig exists before using it > doc: pytest: mention additional requirements for venv > pylibfdt: add requirements.txt for setuptools > > doc/develop/pytest/usage.rst | 4 ++++ > scripts/dtc/pylibfdt/requirements.txt | 1 + > test/py/conftest.py | 5 +++-- > 3 files changed, 8 insertions(+), 2 deletions(-) > --- > base-commit: a333d9e59f6675c9541c34643f334dbf50898647 > change-id: 20251121-a-few-test-py-improvements-b91babfc3e05 > > Best regards, > -- > David Lechner <[email protected]>
