On Thu, Jan 08, 2026 at 05:20:52PM +0100, Quentin Schulz wrote:
> Hi Heinrich,
> 
> On 12/25/25 11:13 AM, Heinrich Schuchardt wrote:
> > Dear Tom,
> > 
> > The following changes since commit
> > baf076aeb32dcdd2b022405088c3288ffc160fcf:
> > 
> >    Merge branch 'staging' of https://
> > eur02.safelinks.protection.outlook.com/?
> > url=https%3A%2F%2Fsource.denx.de%2Fu-boot%2Fcustodians%2Fu-boot- 
> > tegra&data=05%7C02%7Cquentin.schulz%40cherry.de%7Cf87dd0f90d6b45f7ce7508de439e34da%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C639022543931009936%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=UrWok7nyXyLT97iLd1o%2FxUIuYtwkRz7DcO8D8ogdH7Y%3D&reserved=0
> > into next (2025-12-23 08:11:36 -0600)
> > 
> > are available in the Git repository at:
> > 
> >    https://eur02.safelinks.protection.outlook.com/?
> > url=https%3A%2F%2Fsource.denx.de%2Fu-boot%2Fcustodians%2Fu-boot- 
> > efi.git&data=05%7C02%7Cquentin.schulz%40cherry.de%7Cf87dd0f90d6b45f7ce7508de439e34da%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C639022543931023452%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=noF%2B4QWCdd9uds%2FLv5wxiCynT7PNTHKQFnDHXYn2%2BqQ%3D&reserved=0
> > tags/efi-next-20251225
> > 
> > for you to fetch changes up to 4c105d2ae7b0f847668ff1ef6b410f63ab4290b7:
> > 
> >    doc: board: starfive: update jh7110 common description (2025-12-24
> > 09:41:57 +0100)
> > 
> > ----------------------------------------------------------------
> > Pull request efi-next-20251225
> > 
> > Documentation:
> > 
> > * Update StarFive Jh7110 common description.
> > * Describe command line options of the bdinfo command.
> > * Describe configuration dependencies of the bdinfo command.
> > 
> > UEFI:
> > 
> > * Trigger capsule updates with automatically generated boot options.
> > * In the LoadImage unit test add a check that device-paths are correctly
> >    used.
> > * In the variables at runtime test remove an unnecessary
> >    __efi_runtime_data attribute.
> > 
> > Others:
> > 
> > * Let the bdinfo command output device-tree information even if LMB is
> >    no used.
> > * Add long help texts for all options of the bdinfo command.
> > 
> > ----------------------------------------------------------------
> > E Shattow (1):
> >        doc: board: starfive: update jh7110 common description
> > 
> > Heinrich Schuchardt (4):
> >        efi_selftest: Enhance LoadImage test
> >        efi_selftest: remove unnecessary __efi_runtime_data attribute
> >        test: dm: clk_ccf: clean up assert statements
> >        cmd/bdinfo: LMB and device-tree are not related
> > 
> > Ilias Apalodimas (1):
> >        efi_loader: Trigger capsule updates with automatically generated
> > boot options
> > 
> > Quentin Schulz (3):
> >        cmd: bdinfo: provide long help with all options
> >        doc: cmd: bdinfo: specify required dependency for some info
> 
> In the future, can you please consider editing the commit log when you're
> doing modifications to patches when merging them?
> 
> Something like
> 
> Signed-off-by: Quentin Schulz <[email protected]>
> [added symbol dependency to lmb_dump_all]
> [removed CONFIG_LMB as symbol dependency of devicetree]
> Reviewed-by: Heinrich Schuchardt <[email protected]>
> 
> ? So that there's some info about what was changed from the patch that was
> sent to the ML and by whom?
> 
> (Maybe ask for permission before doing this as well, or maybe we should have
> documentation on what can be expected from maintainers to that regard? I
> know Buildroot does this a lot (and often silently), Yocto sometimes, but
> the kernel not too often, and it's the first time (that I know of) it
> happens to me in U-Boot :) )
> 
> I'm generally not a fan of my patches being silently modified before
> merging, though here it ended up fine so thanks for sparing me the rebase+v3
> respin I was thinking about starting to do :)
 
I have, over the years, sometimes added [trini: foo] and a SoB tag, and
more recently made us of b4 making merge commits of a series trivial
(which is great and this is yet another reminder to anyone reading that
cover letters on series are important because they become the merge
commit message) and dealing with both merge issues and trivially correct
changes such as spelling or spacing fixes in the merge commit itself.

What this does speak to however is that we need to document the
expectations here as it's clear implicit expectations have been
violated, and that's on me in the end to make sure are clear and
explicit. I'll write up something for doc/develop/process.rst in the
next few days.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to