Hi Aswin, On 13/01/2026 12:54, Aswin Murugan wrote: > This patch series introduces a comprehensive OF_LIVE device tree fixup > infrastructure for Qualcomm Snapdragon platforms. The implementation > provides runtime device tree modifications to pass platform-specific > information from SMEM to the operating system through device tree. > > Qualcomm Snapdragon SoCs require runtime device tree modifications to > provide accurate platform information that cannot be statically defined > in device tree source files. This includes: > > - Board-specific identification and variant information > - DDR memory configuration > - Hardware subset parts > - SoC-specific device node adjustments
I have to be honest, this is a lot of words to not really explain anything. What motivated this series? What does it actually do? Why is it needed? This applies for the individual patches too, the commit message needs to contain the context that isn't in the patch itself. OF_LIVE refers to U-Boot building an internal representation of the devicetree (take a look at the git history for mach-snapdragon/of_fixup.c). I don't think this is a relevant to your series which is modifying the FDT before the OS boots... What are the DT nodes/properties being set, how does it look in the end? Are the bindings for these properties upstream? I think a need a better understanding of this before looking at the contents of these patches. > > This patch series depends on the following patch [1], which adds the > socinfo header file. > > [1] > https://lore.kernel.org/all/[email protected]/ > > Aswin Murugan (2): > mach-snapdragon: Add OF_LIVE device tree fixup handlers > arm: snapdragon: Integrate OF_LIVE fixup handlers in ft_board_setup() > > arch/arm/mach-snapdragon/Makefile | 3 + > arch/arm/mach-snapdragon/chipinfo_def.h | 90 ++++++ > arch/arm/mach-snapdragon/of_fixup.c | 114 +++++++ > .../mach-snapdragon/qcom_fixup_boardinfo.c | 228 ++++++++++++++ > arch/arm/mach-snapdragon/qcom_fixup_ddrinfo.c | 214 +++++++++++++ > .../arm/mach-snapdragon/qcom_fixup_handlers.h | 70 +++++ > .../mach-snapdragon/qcom_fixup_subsetparts.c | 291 ++++++++++++++++++ > arch/arm/mach-snapdragon/rampart.h | 236 ++++++++++++++ > 8 files changed, 1246 insertions(+) > create mode 100644 arch/arm/mach-snapdragon/chipinfo_def.h > create mode 100644 arch/arm/mach-snapdragon/qcom_fixup_boardinfo.c > create mode 100644 arch/arm/mach-snapdragon/qcom_fixup_ddrinfo.c > create mode 100644 arch/arm/mach-snapdragon/qcom_fixup_handlers.h > create mode 100644 arch/arm/mach-snapdragon/qcom_fixup_subsetparts.c > create mode 100644 arch/arm/mach-snapdragon/rampart.h > -- // Casey (she/her)
