Hi Balaji,

On Wed, Jan 07, 2026 at 03:20:38PM +0530, Balaji Selvanathan wrote:
> The default value of CONFIG_FASTBOOT_BUF_ADDR is 0, which causes
> NULL pointer dereference during fastboot commands when users dont
> provide "-l" option in fastboot usb command.

On Qcom platforms, we usually rely on LMB allocations for fastboot
address, see here [1]. So I would rather suggest you to adapt fastboot
common code [2] to consume fastboot address from env (fastboot_addr_r)
in case CONFIG_FASTBOOT_BUF_ADDR is 0. Then it will be a generic fix
applicable for all the Qcom platforms.

[1] arch/arm/mach-snapdragon/board.c:545 env_set_hex("fastboot_addr_r", addr)
[2] drivers/fastboot/fb_common.c:235 fastboot_init()

-Sumit

> 
> Set it to safe and sufficiently large region in RAM
> of the QCS615 and QCM6490 boards, to prevent crashes.
> 
> Signed-off-by: Balaji Selvanathan <[email protected]>
> ---
>  configs/qcm6490_defconfig     | 2 ++
>  configs/qcom_qcs615_defconfig | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/configs/qcm6490_defconfig b/configs/qcm6490_defconfig
> index 54eb5dedaec..618098c8860 100644
> --- a/configs/qcm6490_defconfig
> +++ b/configs/qcm6490_defconfig
> @@ -13,3 +13,5 @@ CONFIG_TEXT_BASE=0x9fc00000
>  CONFIG_REMAKE_ELF=y
>  
>  CONFIG_DEFAULT_DEVICE_TREE="qcom/qcs6490-rb3gen2"
> +
> +CONFIG_FASTBOOT_BUF_ADDR=0xd8800000
> diff --git a/configs/qcom_qcs615_defconfig b/configs/qcom_qcs615_defconfig
> index 2468267b955..14043b4f23d 100644
> --- a/configs/qcom_qcs615_defconfig
> +++ b/configs/qcom_qcs615_defconfig
> @@ -20,3 +20,5 @@ CONFIG_REMAKE_ELF=y
>  
>  # Address where U-Boot will be loaded
>  CONFIG_TEXT_BASE=0x9fc00000
> +
> +CONFIG_FASTBOOT_BUF_ADDR=0xa1600000
> -- 
> 2.34.1
> 

Reply via email to