Hi Quentin,

On 1/15/2026 12:26 PM, Quentin Schulz wrote:
> Hi Jonas,
> 
> On 1/8/26 12:07 AM, Jonas Karlman wrote:
>> Add Kconfig option OF_SYSTEM_SETUP=y to support booting ROCK 5C Lite
>> boards with a RK3582 SoC. CPU and GPU cores are failed based on ip-state
>> and policy.
>>
>> Tested on a ROCK 5C Lite v1.1:
>>
>>    cpu-code: 35 82
>>    ip-state: 00 80 00 (otp)
>>    ip-state: c0 9e 04 (policy)
>>    remove cpu-map cluster2
>>    fail gpu
>>    fail rkvdec1
>>    fail rkvenc1
>>    fail cpu cpu@600
>>    fail cpu cpu@700
>>
>> Signed-off-by: Jonas Karlman <[email protected]>
>> ---
>> v4: Update commit message to reflect updated policy
>> v3: Update commit message to reflect updated policy
>> v2: New patch
>> ---
>>   arch/arm/mach-rockchip/rk3588/Kconfig | 9 +++++----
>>   configs/rock-5c-rk3588s_defconfig     | 1 +
>>   doc/board/rockchip/rockchip.rst       | 2 +-
>>   3 files changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig 
>> b/arch/arm/mach-rockchip/rk3588/Kconfig
>> index 60c16d2f32d2..675f13ab66d7 100644
>> --- a/arch/arm/mach-rockchip/rk3588/Kconfig
>> +++ b/arch/arm/mach-rockchip/rk3588/Kconfig
>> @@ -286,14 +286,15 @@ config TARGET_ROCK_5_ITX_RK3588
>>        Powered by either 12V, ATX power-supply or PoE
>>   
>>   config TARGET_ROCK_5C_RK3588S
>> -    bool "Radxa ROCK 5C RK3588S2 board"
>> +    bool "Radxa ROCK 5C/5C Lite"
>>      help
>> -      Radxa ROCK 5C is a Rockchip RK3588S2 based single board computer.
>> +      Radxa ROCK 5C/5C Lite is a Rockchip RK3588S2/RK3582 based SBC (Single
>> +      Board Computer) by Radxa.
>>   
>>        Specification:
>>   
>> -      Quad A76 and Quad A55 CPU
>> -      6 TOPS NPU
>> +      Quad/Dual A76 and Quad A55 CPU
> 
> Considering the code seems to handle removal of little cores too as well 
> as all big cores, is this something we should be mentioning?

The code is trying to be as dynamic as possible, however if I
understand correctly a RK3528 should at most have one A76 cluster in
bad/failed state, and if all cpu cores is fine there is a policy to
disable one of the A76 cluster anyway. So this text change is correct
in that the Lite version have Dual A76 and Quad A55.

Regards,
Jonas

> 
> Reviewed-by: Quentin Schulz <[email protected]>
> 
> Thanks!
> Quentin

Reply via email to