On Wed, Jan 28, 2026 at 1:47 PM Tom Rini <[email protected]> wrote:
> On Mon, Jan 26, 2026 at 10:11:20AM +0800, Peng Fan wrote: > > On Thu, Jan 22, 2026 at 10:12:36AM -0300, Mateus Lima wrote: > > >On Wed, Jan 21, 2026 at 11:13 PM Peng Fan <[email protected]> wrote: > > > > > >> On Tue, Jan 13, 2026 at 11:23:01AM -0300, Mateus Lima Alves wrote: > > >> >This patch adds CPLD support via IFC to the ls1021a-iot board. > > >> > > > >> >Signed-off-by: Mateus Lima Alves <[email protected]> > > >> > > >> CI report build failure. > > >> > > >> CC drivers/video/hitachi-tx10d07vm0baa.o > > >> In file included from drivers/misc/fsl_ifc.c:8: > > >> include/fsl_ifc.h:16:10: fatal error: asm/ppc.h: No such file or > directory > > >> 16 | #include <asm/ppc.h> > > >> | ^~~~~~~~~~~ > > >> compilation terminated. > > >> make[3]: *** [scripts/Makefile.build:271: drivers/misc/fsl_ifc.o] > Error 1 > > >> make[2]: *** [scripts/Makefile.build:492: drivers/misc] Error 2 > > >> make[2]: *** Waiting for unfinished jobs.... > > >> CC drivers/rtc/ht1380.o > > >> CC drivers/video/hitachi_tx18d42vm_lcd.o > > >> CC drivers/rtc/i2c_rtc_emul.o > > >> > > >> make[1]: *** [Makefile:2191: drivers] Error 2 > > >> make: *** [Makefile:362: __build_one_by_one] Error 2 > > >> Cleaning up project directory and file based variables > > >> > > >> Regards > > >> Peng > > >> > > >Hi Peng, > > > > > >Thank you for the test, and apologies for not having validated the > patch on > > >other targets. > > >In fact, this driver was not being used by any target (neither ARM nor > PPC) > > >and after this patch it became enabled again. However, PPC targets fail > > >when trying to include the asm/ppc.h header, which is not available for > > >some reason. > > > > > >For now, I am thinking of submitting a v3 of the patch adding an > explicit > > >dependency on ARM, something like: > > > > > >+ depends on ARM > > > > > >This way we would avoid building the driver for PPC targets. > > >What do you think about this approach? > > > > It should be ok. > > This has lead to: > WARNING: unmet direct dependencies detected for FSL_IFC > Depends on [n]: ARM [=n] > Selected by [y]: > - ARCH_P1010 [=y] && PPC [=y] && MPC85xx [=y] > > WARNING: unmet direct dependencies detected for FSL_IFC > Depends on [n]: ARM [=n] > Selected by [y]: > - ARCH_P1010 [=y] && PPC [=y] && MPC85xx [=y] > > For example on P1010RDB-PB_SPIFLASH. > > -- > Tom > Hi Tom, Yes, I noticed that this warning is appearing now, and before this patch, neither this flag nor fsl_ifc were properly used for compiling PPC targets. Now that I've added more information about this option, it's being considered again during compilation. But in this thread, I commented to Peng Fan that it was possible to build for PPC targets, meaning we wouldn't need to restrict this to ARM targets, but I don't know what setup was used to crash the mentioned PPC target, but in the U-Boot Azure DevOps environment, all targets were built successfully. https://dev.azure.com/u-boot/u-boot/_build/results?buildId=12700&view=results We can use patch v2 in this case, or could Peng Fan please show me how he made his build break? Is it a different environment? BR, Mateus
