Hi Lukasz, Le 15/07/2011 09:34, Lukasz Majewski a écrit : > On Thu, 14 Jul 2011 16:00:23 +0200 > Albert ARIBAUD<[email protected]> wrote: > >> Hi Lukasz, >> >> Le 11/07/2011 09:41, Lukasz Majewski a écrit : >>> Signed-off-by: Lukasz Majewski<[email protected]> >>> Cc: Minkyu Kang<[email protected]> >>> Cc: Aneesh V<[email protected]> >>> --- >> >> Can you please submit a V2 patch in which the commit message provides >> a rationale for turning the data cache off? People who want to turn >> it on later will benefit from the info. >> >> Amicalement, > > Hi Albert, > > Rationale for turning OFF D cache: > > 1. Before change introduced in commit > SHA1:c2dd0d45540397704de9b13287417d21049d34c6 the D-cache for > GONI/Universal_c210 targets was disabled. This change was supposed to > preserve this state. > > 2. I've done some investigation about enabling D-cache support. It > turned out, that some drivers (which are already posted or are in the > queue for posting to u-boot list) have had problems with D-cache > coherency. > > This commit shall be treated as a temporal solution. After solving > cache management (and coherency) problems the D-cache would be > definitely enabled.
Thanks. Except for a typo (Temporal-> Temporary), please put this rationale in the commit message for V2. Amicalement, -- Albert. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
