On 29/01/2026 15:53, Marek Vasut wrote:
> On 1/29/26 11:18 AM, Jerome Forissier wrote:
>> Hi Marek,
>>
>> On 29/01/2026 01:23, Marek Vasut wrote:
>>> Currently, the LWIP wget command prints excessive amount of progress
>>> indicator '#' for very long file downloads,
>>
>> So true! ;-)
>>
>>> limit this to one line
>>> that scales according to transfer size.
>>>
>>> The HTTP server does report the size of the entire file in protocol
>>> headers, which are received before the actual data transfer. Cache
>>> this information and use it to adaptively print progress indicator
>>> '#' until it fills one entire line worth of '#', which indicates the
>>> transfer has completed. This way, long transfers don't print pages of
>>> '#', but every transfer will print exactly one line worth of '#'. The
>>> algorithm for '#' printing is the same as TFTP tsize one.
>>
>> That's not one line strictly speaking, it is 50 characters.
>> Like I suggested re. your TFTP patch, perhaps a percent-based format
>> would be better?
>>
>> 0%....10%....20%... etc.
> 
> I would like to retain as much compatibility with the old network stack as 
> possible, to make the switch over easy for existing users.

It is a valid argument but I doubt changing the display can break important
things, aside from test frameworks maybe, but that should be manageable.
Tom what do you think?

> 
> Is there already such a "pretty printing" function available somewhere ?

Not that I know of :-/

>> In any case:
>>
>> Acked-by: Jerome Forissier <[email protected]>
> Thank you
> 
> (it seems someone rm'd a character from the AB string above, so I reinstated 
> it according to the source email address)

That someone might be me. Muscle memory not yet trained.

Thanks,
-- 
Jerome

Reply via email to