Hi Francesco, > Subject: Re: [PATCH 4/4] imx9: Kconfig: Enable remoteproc for i.MX95 ... > > > > diff --git a/arch/arm/mach-imx/imx9/Kconfig > > b/arch/arm/mach-imx/imx9/Kconfig index > d9f97e4328c..7051e086072 100644 > > --- a/arch/arm/mach-imx/imx9/Kconfig > > +++ b/arch/arm/mach-imx/imx9/Kconfig > > @@ -134,6 +134,12 @@ config TARGET_IMX95_19X19_EVK > > imply BOOTSTD_BOOTCOMMAND > > imply BOOTSTD_FULL > > imply OF_UPSTREAM > > + select CMD_REMOTEPROC > > + select REMOTEPROC_IMX > > + select REGMAP > > + select SYSCON > > + select IMX_SM_LMM > > + select IMX_SM_CPU > > Why doing this with a select in the Kconfig? > > I would expect either > - you enable what you need in the defconfig > - you add the select to the imx95 soc
There are many defconfigs in NXP downstream for a single board: $ls -l configs/imx95_19x19_* | wc -l 21 I would not changes so many defconfigs. I understand there is only 1 defconfig for this board in upstream, but to ease NXP upgrading U-Boot to new version, I choose to change Kconfig. Changing to upstream defconfig in upstream is fine for now. Fabio, What's your opinion here? Thanks, Peng. > > Francesco
