On 1/30/26 1:29 AM, Jonas Karlman wrote:
Refactor asix_send_common() to closer match the Linux variant.
This change has no intended functional change, it only makes the code
closer match the Linux ASIX AX88xxx driver.
Signed-off-by: Jonas Karlman <[email protected]>
---
drivers/usb/eth/asix88179.c | 43 +++++++++++++++----------------------
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/usb/eth/asix88179.c b/drivers/usb/eth/asix88179.c
index 7d7cdeb60ebf..a9dff23e83bb 100644
--- a/drivers/usb/eth/asix88179.c
+++ b/drivers/usb/eth/asix88179.c
@@ -487,40 +487,31 @@ static int asix_send_common(struct ueth_data *dev,
struct asix_private *dev_priv,
void *packet, int length)
{
- int err;
- u32 packet_len, tx_hdr2;
- int actual_len, framesize;
- ALLOC_CACHE_ALIGN_BUFFER(unsigned char, msg,
- PKTSIZE + (2 * sizeof(packet_len)));
+ u32 tx_hdr1, tx_hdr2;
+ int actual_len, ret;
+ ALLOC_CACHE_ALIGN_BUFFER(unsigned char, msg, PKTSIZE + 8);
Please at least add a code comment about what this 8 means, it was clear
from the previous sizeof() use, now it is a magic number.
