Hi Michal,
On Fri, Jan 30, 2026 at 09:29:49AM +0100, Michal Simek wrote:
>
>
>>
>> Add an entry for SPL?
>
>Why? I don't have a need for it and someone should test it if this should be
>used in SPL. That can be done on the top of this when tested.
I see.
>
>
>> > #
>> > + * Copyright (C) 2025 - 2026, Advanced Micro Devices, Inc.
>>
>> Drop 2025?
>
>Why? Driver was developed in 2025 but upstreaming happens in 2026.
I think the year should start from the day of upstreaming. Not sure.
Tom may comment.
>
>>
>> > + *
>> > +
>> > + /* Request all GPIOs described in the controller node */
>> > + for (i = 0; i < ngpio; i++) {
>> > + d = &priv->descs[i];
>> > + ret = gpio_request_by_name_nodev(node, "gpios", i,
>> > + &d->real_gpio, GPIOD_IS_OUT);
>>
>> This will configure the GPIO as output and ACTIVE high/low flag will also
>> be used per my understanding.
>>
>> Should the dir and value be deferred until set_value is invoked?
>
>It is clear that it should be output because you just setting it up later.
>But I don't have any issue not to pass any flag here.
>Please let me know if you want me to change it to 0.
Yes, please. Configure it only when user request.
Thanks,
Peng
>
>Thanks,
>Michal
>
>
