On Tue, 3 Feb 2026 at 13:29, Maarten Brock <[email protected]> wrote: > > > -----Original Message----- > > From: Michal Simek <[email protected]> > > Sent: Tuesday 3 February 2026 11:10 > > To: Maarten Brock <[email protected]>; [email protected]; > > [email protected] > > Cc: Ilias Apalodimas <[email protected]>; Heinrich Schuchardt > > <[email protected]>; Shantur Rathore <[email protected]>; Tom Rini > > <[email protected]> > > Subject: Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function > > > > Hi, > > > > On 2/3/26 10:44, Maarten Brock wrote: > > > Hello Michal, > > > > > > Why are the new function names non-symmetrical? > > > efi_var_to_storage <-> efi_var_from ... > > > > Ilias was asking about these names in v5 review. > > I'm sure he meant something different from what you implemented. > > > I am ok with this with a small nit. > > Can we rename efi_var_read/write to efi_var_from/to_storage? I want to > > make it clealer what these functions are used for > > > > With the changes above > > Reviewed-by: Ilias Apalodimas <[email protected]> > > I think Ilias meant to use: > efi_var_from_storage & efi_var_to_storage
Yes , thanks for claryfying this /Ilias > and not: > efi_var_from & efi_var_to_storage > > > > > Thanks, > > Michal > > Kind regards, > Maarten
