> -----邮件原件----- > 发件人: Fabio Estevam <[email protected]> > 发送时间: 2026年2月6日 11:59 > 收件人: Alice Guo (OSS) <[email protected]> > 抄送: dl-uboot-imx <[email protected]>; [email protected]; Stefano > Babic <[email protected]>; Tom Rini <[email protected]>; Peng Fan > <[email protected]>; Ye Li <[email protected]>; Jindong Yue > <[email protected]>; Jacky Bai <[email protected]>; Marek Vasut > <[email protected]>; Rasmus Villemoes <[email protected]>; > Ross, Fedor <[email protected]>; João Paulo Gonçalves > <[email protected]>; Patrice Chotard > <[email protected]>; Valentin Caron <[email protected]>; > Vinh Nguyen <[email protected]>; Sam Protsenko > <[email protected]>; Ranjani Vaidyanathan > <[email protected]>; Ji Luo <[email protected]>; Frank Li > <[email protected]>; Sumit Garg <[email protected]>; Adam > Ford <[email protected]>; Frieder Schrempf > <[email protected]>; David Zang <[email protected]>; > Andrew Goodbody <[email protected]>; Sumit Garg > <[email protected]>; Marek Vasut <[email protected]>; Joseph Guo > <[email protected]>; [email protected]; Alice Guo > <[email protected]> > 主题: Re: [PATCH v1 07/12] arm: imx952: Add watchdog base address > definitions > > Hi Alice, > > On Thu, Feb 5, 2026 at 12:16 PM <[email protected]> wrote: > > > > From: Alice Guo <[email protected]> > > > > Add WDG3, WDG4 and WDG5 base addresses for i.MX952. > > > > Signed-off-by: Alice Guo <[email protected]> > > --- > > arch/arm/include/asm/arch-imx9/imx-regs.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/include/asm/arch-imx9/imx-regs.h > b/arch/arm/include/asm/arch-imx9/imx-regs.h > > index 2d084e5227a..7c7a34f74af 100644 > > --- a/arch/arm/include/asm/arch-imx9/imx-regs.h > > +++ b/arch/arm/include/asm/arch-imx9/imx-regs.h > > @@ -17,6 +17,11 @@ > > > > #define ANATOP_BASE_ADDR 0x44480000UL > > > > +#ifdef CONFIG_IMX952 > > +#define WDG3_BASE_ADDR 0x420b0000UL > > +#define WDG4_BASE_ADDR 0x420c0000UL > > +#define WDG5_BASE_ADDR 0x420d0000UL > > +#else > > #ifdef CONFIG_IMX94 > > #define WDG3_BASE_ADDR 0x49220000UL > > #define WDG4_BASE_ADDR 0x49230000UL > > @@ -25,6 +30,7 @@ > > #define WDG4_BASE_ADDR 0x424a0000UL > > #endif > > #define WDG5_BASE_ADDR 0x424b0000UL > > +#endif > > Can we improve this and retrieve the watchdog base address from the > devicetree?
Hi Fabio, Thanks for the suggestion. Using the device tree would be cleaner, but this patch follows the existing i.MX9 imx-regs.h pattern. I suggest we merge this patch to keep consistency with the current codebase. Thoughts? Best regards, Alice Guo
