No worries. I'm still interested in upstreaming this patch and the corresponding DT for my device into the linux kernel.
The error you've got would be expected if you didn't disable the pinctrl part of the older S5P (see Patch v2 1/2). Please be sure to disable it in order for my suggested driver to compile correctly. The older driver didn't support newer style DTs pinctrl, which my device uses and will be upstreamed soon. I acknowledge, that this is a less than optimal solution and I'm willing to discuss alternatives. The issue appears because the older pinmux driver did much more than the newer pinctrl driver I've written does. Also I just noticed that I left behind "Copyright Linaro Ltd." in the header of pinctrl-exynos5250.c so please don't merge this yet. A v3 is obligatory at this point. Best regards Lukas Timmermann On Mon, Feb 02, 2026 at 05:33:50PM +0900, Minkyu Kang wrote: > Dear Timmermann, > > Sorry I missed this patch.. > > I tested this patch but I've got compile errors. > Could you please check?; tested with smdk5250. > > /opt/toolchain/gcc-arm-none-eabi-10.3-2021.10/bin/arm-none-eabi-ld: > drivers/gpio/s5p_gpio.o: in function `gpio_set_pull': > /home/work/git/u-boot-samsung/drivers/gpio/s5p_gpio.c:240: multiple > definition of `gpio_set_pull'; > arch/arm/mach-exynos/pinmux.o:pinmux.c:(.text.gpio_set_pull+0x0): first > defined here > /opt/toolchain/gcc-arm-none-eabi-10.3-2021.10/bin/arm-none-eabi-ld: > drivers/gpio/s5p_gpio.o: in function `gpio_set_drv': > /home/work/git/u-boot-samsung/drivers/gpio/s5p_gpio.c:246: multiple > definition of `gpio_set_drv'; > arch/arm/mach-exynos/pinmux.o:pinmux.c:(.text.gpio_set_drv+0x0): first > defined here > /opt/toolchain/gcc-arm-none-eabi-10.3-2021.10/bin/arm-none-eabi-ld: > drivers/gpio/s5p_gpio.o: in function `gpio_cfg_pin': > /home/work/git/u-boot-samsung/drivers/gpio/s5p_gpio.c:252: multiple > definition of `gpio_cfg_pin'; > arch/arm/mach-exynos/pinmux.o:/home/work/git/u-boot-samsung/arch/arm/mach-exynos/pinmux.c:952: > first defined here > > Thanks, > Minkyu Kang. >
