On 2/11/26 16:06, Ilias Apalodimas wrote:
Hi Michal
Since you'll have to send a v8 a few nits.
[...]
}
/**
- * efi_var_to_file() - save non-volatile variables as file
+ * efi_var_to_storage() - save non-volatile variables as file
it's not 'as file' anymore right?
*
* File ubootefi.var is created on the EFI system partion.
And this needs an update "If they are stored to file..." etc
*
* Return: status code
*/
-efi_status_t efi_var_to_file(void)
+efi_status_t efi_var_to_storage(void)
{
efi_status_t ret;
struct efi_var_file *buf;
@@ -85,7 +85,7 @@ out:
}
/**
- * efi_var_from_file() - read variables from file
+ * efi_var_from_storage() - read variables from file
same here
*
* File ubootefi.var is read from the EFI system partitions and the variables
* stored in the file are created.
and here
[...]
You can keep the r-b tags, as it's just comment updates
This is actually correct. Because this code is used only for storing variables
as file on filesystem.
I updated include/efi_variable.h which is generic and shared between fs/sf but
lib/efi_loader/efi_var_file.c is only for saving/reading file on FS.
M
