On Tue, 2026-02-10 at 17:22 +0100, Julien Stephan wrote: > Introduce ufshcd_ops_phy_initialization() as a helper for invoking > the > phy_initialization callback from ufs_hba_ops. > > This mirrors the existing helper pattern used for other ufs_hba_ops > callbacks and keeps the call sites consistent and easier to maintain. > > Signed-off-by: Julien Stephan <[email protected]> > --- > drivers/ufs/ufs-rockchip.c | 10 ++++------ > drivers/ufs/ufs.h | 8 ++++++++ > 2 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/drivers/ufs/ufs-rockchip.c b/drivers/ufs/ufs-rockchip.c > index 0384244387d..cad753d5990 100644 > --- a/drivers/ufs/ufs-rockchip.c > +++ b/drivers/ufs/ufs-rockchip.c > @@ -30,12 +30,10 @@ static int ufs_rockchip_hce_enable_notify(struct > ufs_hba *hba, > ufshcd_dme_reset(hba); > ufshcd_dme_enable(hba); > > - if (hba->ops->phy_initialization) { > - err = hba->ops->phy_initialization(hba); > - if (err) > - dev_err(hba->dev, > - "Phy init failed (%d)\n", err); > - } > + ret = ufshcd_ops_phy_initialization(hba); > + if (err) > + dev_err(hba->dev, > + "Phy init failed (%d)\n", err); > > return err; > } > diff --git a/drivers/ufs/ufs.h b/drivers/ufs/ufs.h > index bc839a43704..74125b1ab31 100644 > --- a/drivers/ufs/ufs.h > +++ b/drivers/ufs/ufs.h > @@ -756,6 +756,14 @@ static inline int > ufshcd_ops_link_startup_notify(struct ufs_hba *hba, > return 0; > } > > +static inline int ufshcd_ops_phy_initialization(struct ufs_hba *hba) > +{ > + if (hba->ops && hba->ops->phy_initialization) > + return hba->ops->phy_initialization(hba); > + > + return 0; > +} > + > static inline int ufshcd_vops_device_reset(struct ufs_hba *hba) > { > if (hba->ops && hba->ops->device_reset) >
Reviewed-by: Macpaul Lin <[email protected]> Thanks! Macpaul Lin
