Hi all, From: Quentin Schulz < [email protected]> > > Hi Heinrich, > > On 2/25/26 7:35 AM, Heinrich Schuchardt wrote: > > Symbol CONFIG_SPL_BINMAN_FDT does not exist. > > Don't select it. > > > > Maybe they wanted BINMAN_FDT here, but for brcp150_defconfig it's already > enabled.
The intention is to allow initialization of FPGAs already in SPL on some of our boards (bcp150). The FPGA bitstream is located via the binman entries in the devicetree. Doing the initialization of the FPGA already in SPL saves a little startup time as the initialization of IP cores in the FPGA can than happen in parallel with the rest of the CPU boot. > While there's > > obj-$(CONFIG_$(PHASE_)BINMAN_FDT) += binman.o > > in lib/Makefile, it's guarded by ifndef CONFIG_XPL_BUILD, which means it's > the same as CONFIG_BINMAN_FDT above. > > Also, there's a CONFIG_IS_ENABLED(BINMAN_FDT) in common/board_r.c but my > understanding is that this is for post-reloc, meaning U-Boot proper, so > SPL_BINMAN_FDT won't do anything even if defined in Kconfig, so: > > Reviewed-by: Quentin Schulz <mailto:[email protected]> Just by reviewing the code I think that both the patch by Heinrich as well as the explanation by Quentin make sense and this define was not necessary. But I'm currently working from home without access to the required boards to test the patch. I will provide more detailed feedback next week. Regards, Wolfgang
