Hi Fabio, Thank you for the review, I will fix these issues in the next version.
Best regards, Simona On Tue, Mar 10, 2026 at 01:12:28PM -0300, Fabio Estevam wrote: > On Tue, Mar 10, 2026 at 8:44 AM Simona Toaca (OSS) > <[email protected]> wrote: > > > > From: Simona Toaca <[email protected]> > > > > Call qb save automatically in the board-specific > > spl_board_init(), if SPL_QB option is enabled. This > > makes sure qb_save is called before any image loading > > is done by the SPL. > > Why do we need this? What does "QB" mean? > > Please improve the commit message by providing more context and an > explanation of what you want to achieve. > > > Signed-off-by: Simona Toaca <[email protected]> > > --- > > arch/arm/include/asm/mach-imx/qb.h | 2 ++ > > arch/arm/mach-imx/Kconfig | 7 +++++++ > > arch/arm/mach-imx/imx9/Makefile | 4 +++- > > arch/arm/mach-imx/imx9/qb.c | 9 +++++++++ > > board/nxp/imx94_evk/spl.c | 6 +++++- > > board/nxp/imx95_evk/spl.c | 6 +++++- > > 6 files changed, 31 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/include/asm/mach-imx/qb.h > > b/arch/arm/include/asm/mach-imx/qb.h > > index 5efe68f0a60..4f923d79e7a 100644 > > --- a/arch/arm/include/asm/mach-imx/qb.h > > +++ b/arch/arm/include/asm/mach-imx/qb.h > > @@ -10,4 +10,6 @@ > > > > bool qb_check(void); > > int qb(int qb_dev, int qb_bootdev, bool save); > > +void spl_qb_save(void); > > + > > #endif > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > > index 17aad696648..069b25c6241 100644 > > --- a/arch/arm/mach-imx/Kconfig > > +++ b/arch/arm/mach-imx/Kconfig > > @@ -71,6 +71,13 @@ config CSF_SIZE > > Define the maximum size for Command Sequence File (CSF) binary > > this information is used to define the image boot data. > > > > +config SPL_IMX_QB > > + bool "Run qb save during SPL" > > What does "qb save" mean? Please explain here and in the commit message. > > How does a user know if "qb save" should run in SPL or not? > > > + default n > > No need to pass "default n". Drop it. > > > +void spl_qb_save(void) > > +{ > > + int dev = spl_boot_device(); > > + > > + /** Save QB data on current boot device */ > > Please use a single /* instead of /**
