----- "Lei Wen" <[email protected]> wrote: > Hi Ajay, > > On Tue, Jul 19, 2011 at 12:01 PM, Ajay Bhargav > <[email protected]> wrote: > > > >> How about merge this into current mvmfp.c? Just add some function > >> into > >> it, then no need another c file. > >> > >> Best regards, > >> Lei > >> > > > > Hi Lei, > > > > According to current ongoing development there is generic GPIO > framework being introduced. Its good if we keep gpio separate though > they are connected to MFP too, It makes more sense if they are kept in > different file. lets see what Prafulla has to say about this. > > > Ok. > BTW, I also have some comments towards your patch. > You define a huge structure in > arch/arm/include/asm/arch-armada100/gpio.h, which don't looks so good > to me. >
Comments are welcome. I know its huge.. I just followed what is suggested by Wolfgang. He told not to use BASE+OFFSET thing. I am bit confused here whom to follow :) > > Macro here save a lot space, and keep the code clean. > > Best regards, > Lei > Prafulla is suggesting something.. Let me ask him how he want this. Regards, Ajay Bhargav _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
