On 3/16/26 10:01 AM, Julien Stephan wrote: > Le lun. 16 mars 2026 à 15:34, David Lechner <[email protected]> a écrit : >> >> On 3/16/26 7:38 AM, Julien Stephan wrote: >>> Le mer. 11 mars 2026 à 01:17, David Lechner <[email protected]> a écrit >>> : >>>> >>>> From: Chris-QJ Chen <[email protected]> >>>> >>>> Add basic defconfigs for Genio 520 and 720 EVKs. >>>> >>>> Signed-off-by: Chris-QJ Chen <[email protected]> >>>> Signed-off-by: Macpaul Lin <[email protected]> >>>> Signed-off-by: David Lechner <[email protected]> >>>> --- >>>> board/mediatek/MAINTAINERS | 7 +++++++ >>>> configs/mt8189.config | 34 >>>> ++++++++++++++++++++++++++++++++++ >>>> configs/mt8371_genio_520_evk_defconfig | 4 ++++ >>>> configs/mt8391_genio_720_evk_defconfig | 4 ++++ >>>> 4 files changed, 49 insertions(+) >>>> >>>> diff --git a/board/mediatek/MAINTAINERS b/board/mediatek/MAINTAINERS >>>> index 446a9e8e53c..4f371592059 100644 >>>> --- a/board/mediatek/MAINTAINERS >>>> +++ b/board/mediatek/MAINTAINERS >>>> @@ -1,3 +1,10 @@ >>>> +MT8189/MT8371/MT8391 EVK >>> >>> Hi David, >>> I would not put MT8189 here since there is no MT8189 EVK >>> >>>> +M: Macpaul Lin <[email protected]> >>>> +S: Maintained >>>> +F: configs/mt8189.config >>>> +F: configs/mt8371_genio_520_evk_defconfig >>>> +F: configs/mt8391_genio_720_evk_defconfig >>> >>> Any reason to have genio_520/genio720 in the defconfig name? >> >> The upstream devicetree name will have "genio-720" in the name, so >> find it strange to call the defconfig something that doesn't match >> the devicetree. >> >> If there is a (not Genio) MT8391 EVK I would expect it to have a >> different devicetree and therefore a different defconfig. >> >>> All other boards we are currently upstreaming don't specify it in >>> their defconfig name: >>> mt8365_evk_defconfig/mt8370_evk_defconfig/mt8390_evk_defconfig ... >>> > > I get your point.. From my understanding, mt8371_evk IS genio_520, so > IMHO there will be no non genio MT8371_EVK. > But, I understand that it makes sense to have the name of the > defconfig matching the name of the device tree.. In that case should > we rename all other defconfigs for mt board? > (8365, 8370,8390,8395..)
The upstream devicetree name for 8365 is mt8365-evk.dts (or MT8365 EVK != Genio 350 EVK and I don't know about it?) For the others though, yes, I think it would be good to be consistent with the naming. And we could also use a #include in 8370 and 8390 to reduce the duplication like I did for 8371 and 8391.
