On Tue, May 05, 2026 at 05:48:41PM +0200, Casey Connolly wrote: > Currently only board/vendor/$(BOARD)/config.mk is supported, add the > additional usecase of having a vendor generic config.mk which will be > used to add a Qualcomm specific make target. > > Additionally, fix the ifdef to correctly check for $(BOARDDIR) rather > than $(BOARD) since that's what is actually used in the fragment path. > > Signed-off-by: Casey Connolly <[email protected]> > --- > config.mk | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-)
A common pattern is to have board/VENDOR/common and I think qualcomm
would benefit from that, and it would make this easier to use elsewhere.
>
> diff --git a/config.mk b/config.mk
> index abed9cb65c6f..28a4228b8fa5 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -53,10 +53,14 @@ ENVDIR=${vendor}/env
> else
> BOARDDIR = $(BOARD)
> ENVDIR=${board}/env
> endif
> +else
> +ifdef VENDOR
> +BOARDDIR = $(VENDOR)
> endif
> -ifdef BOARD
> +endif
> +ifdef BOARDDIR
> sinclude $(srctree)/board/$(BOARDDIR)/config.mk # include board
> specific rules
> endif
>
> ifdef FTRACE
But BOARDDIR is used in some other places, so might this become a
problem overloading it this way? Does this end up working because
there's no "board/" code being used on these platforms?
--
Tom
signature.asc
Description: PGP signature
