Hi Chris,
On 4/27/26 7:55 PM, Chris Morgan wrote:
From: Chris Morgan <[email protected]>
Add support for the Anbernic RG-DS dual-screen handheld gaming device.
Can you please augment the commit log to specify why we need to list
clock-names in CONFIG_OF_SPL_REMOVE_PROPS? It's quite important as it's
not meant to be an oversight! Verbatim what you said in v1 as an answer
to my question is perfectly fine :)
I'm a bit puzzled as to why removing clock-names (I'm assumign the one
in &rk817) helps. Isn't clocks property still here? Don't have time to
investigate today though.
Link: https://anbernic.com/products/rgds
Signed-off-by: Chris Morgan <[email protected]>
---
Changes since V1:
- Added entry to doc/board/rockchip/rockchip.rst.
- Removed &sdhci and added &vccio_sd to u-boot device tree.
- Added rk3568 to board path.
- Corrected defconfig and include files in MAINTAINERS.
- Removed CONFIG_EFI_LOADER, CONFIG_LEGACY_IMAGE_FORMAT, and
CONFIG_DISABLE_CONSOLE from defconfig.
---
.../arm/dts/rk3568-anbernic-rg-ds-u-boot.dtsi | 41 +++++++++++
arch/arm/mach-rockchip/rk3568/Kconfig | 7 ++
board/anbernic/rg-ds_rk3568/Kconfig | 12 +++
board/anbernic/rg-ds_rk3568/MAINTAINERS | 7 ++
configs/anbernic-rg-ds-rk3568_defconfig | 73 +++++++++++++++++++
doc/board/rockchip/rockchip.rst | 1 +
include/configs/anbernic-rg-ds-rk3568.h | 12 +++
7 files changed, 153 insertions(+)
create mode 100644 arch/arm/dts/rk3568-anbernic-rg-ds-u-boot.dtsi
create mode 100644 board/anbernic/rg-ds_rk3568/Kconfig
create mode 100644 board/anbernic/rg-ds_rk3568/MAINTAINERS
create mode 100644 configs/anbernic-rg-ds-rk3568_defconfig
create mode 100644 include/configs/anbernic-rg-ds-rk3568.h
diff --git a/arch/arm/dts/rk3568-anbernic-rg-ds-u-boot.dtsi
b/arch/arm/dts/rk3568-anbernic-rg-ds-u-boot.dtsi
new file mode 100644
index 00000000000..00d57104775
--- /dev/null
+++ b/arch/arm/dts/rk3568-anbernic-rg-ds-u-boot.dtsi
@@ -0,0 +1,41 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include "rk356x-u-boot.dtsi"
We know it's based on rk3568, so include rk3568-u-boot.dtsi instead.
Considering all other boards are including this, I guess it's fine for
now and a follow-up patch to change them all would be ok.
[...]
diff --git a/configs/anbernic-rg-ds-rk3568_defconfig
b/configs/anbernic-rg-ds-rk3568_defconfig
new file mode 100644
index 00000000000..34528b22420
--- /dev/null
+++ b/configs/anbernic-rg-ds-rk3568_defconfig
@@ -0,0 +1,73 @@
+CONFIG_ARM=y
+CONFIG_SKIP_LOWLEVEL_INIT=y
+CONFIG_COUNTER_FREQUENCY=24000000
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_SPL_GPIO=y
+CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3568-anbernic-rg-ds"
+CONFIG_ROCKCHIP_RK3568=y
+CONFIG_ROCKCHIP_RK8XX_DISABLE_BOOT_ON_POWERON=y
+CONFIG_SPL_SERIAL=y
+CONFIG_TARGET_ANBERNIC_RG_DS_RK3568=y
+CONFIG_SYS_LOAD_ADDR=0xc00800
+CONFIG_DEBUG_UART_BASE=0xFE660000
+CONFIG_DEBUG_UART_CLOCK=24000000
+CONFIG_DEBUG_UART=y
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_SPL_FIT_SIGNATURE=y
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_DEFAULT_FDT_FILE="rockchip/rk3568-anbernic-rg-ds.dtb"
+# CONFIG_CONSOLE_MUX is not set
+CONFIG_BOARD_TYPES=y
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_BOARD_RNG_SEED=y
+CONFIG_SPL_MAX_SIZE=0x40000
+# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
+CONFIG_SPL_POWER=y
+CONFIG_SPL_ATF=y
+CONFIG_CMD_PWM=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_MMC=y
+# CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_CLS is not set
+# CONFIG_SPL_DOS_PARTITION is not set
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_LIVE=y
+CONFIG_OF_LIST="rockchip/rk3568-anbernic-rg-ds"
+CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks
assigned-clock-rates assigned-clock-parents"
+CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
+CONFIG_NO_NET=y
Please disable NET instead of enabling NO_NET, I would like all users of
NO_NET to eventually stop using it so we can get rid of it (or make it a
transitional Kconfig symbol once our kbuild supports it).
Looks good to me otherwise!
Cheers,
Quentin
