Hi Nora, On 2026-05-08T08:48:28, Feilke, Alexander <[email protected]> wrote: > board: tq: common: add sysinfo helpers > > Add a number of helpers based on the tq_eeprom sysinfo driver and > related hardware detection features. The helpers set up the U-Boot > environment and fixup the OS Device Tree. > > Signed-off-by: Nora Schiffer <[email protected]> > Signed-off-by: Alexander Feilke <[email protected]> > > board/tq/common/Kconfig | 27 +++++++++++++++++++++++++++ > board/tq/common/Makefile | 4 ++++ > board/tq/common/tq_sysinfo.c | 32 ++++++++++++++++++++++++++++++++ > board/tq/common/tq_sysinfo.h | 18 ++++++++++++++++++ > 4 files changed, 81 insertions(+)
> diff --git a/board/tq/common/tq_sysinfo.h b/board/tq/common/tq_sysinfo.h > @@ -0,0 +1,18 @@ > +#ifndef __TQ_SYSINFO_H > + > +#ifndef CONFIG_XPL_BUILD > + > +void tq_common_sysinfo_setup(void); > + > +#endif > + > +#endif /* __TQ_SYSINFO_H */ The include guard is missing its '#define __TQ_SYSINFO_H' - please add it right after the #ifndef. Also, why hide the prototype behind #ifndef CONFIG_XPL_BUILD? It is cleaner to leave the declaration unconditional and gate the .o via Kconfig - a stray SPL caller will then fail at link time rather than with a confusing 'implicit declaration' warning. > diff --git a/board/tq/common/Kconfig b/board/tq/common/Kconfig > @@ -14,3 +14,30 @@ config TQ_COMMON_SDMMC > +config TQ_COMMON_SPL_BOARD_SETUP > + bool > + depends on SPL Is this option referenced in this series? > diff --git a/board/tq/common/Makefile b/board/tq/common/Makefile > @@ -8,3 +8,7 @@ > +ifneq ($(CONFIG_XPL_BUILD),y) > +obj-$(CONFIG_TQ_COMMON_SYSINFO) += tq_sysinfo.o > +endif Can you use the standard obj-$(CONFIG_$(PHASE_)FOO) pattern here? Then just ensure that TQ_COMMON_SYSINFO is not selected in SPL - that is the convention elsewhere and avoids the matching #ifndef CONFIG_XPL_BUILD in the header. Regards, Simon
