On 5/9/26 5:40 AM, Mikhail Kshevetskiy wrote:
>
> On 5/7/26 00:44, David Lechner wrote:
>> On 5/4/26 8:03 AM, Mikhail Kshevetskiy wrote:
>>> This patch adds U-Boot pin controller and gpio driver for Airoha AN7581 SoC.
>>>
>>> Signed-off-by: Mikhail Kshevetskiy <[email protected]>
>>> ---
>>> drivers/pinctrl/airoha/Kconfig | 5 +
>>> drivers/pinctrl/airoha/Makefile | 2 +
>>> drivers/pinctrl/airoha/pinctrl-an7581.c | 1074 +++++++++++++++++++++++
>>> 3 files changed, 1081 insertions(+)
>>> create mode 100644 drivers/pinctrl/airoha/pinctrl-an7581.c
>>>
>>> diff --git a/drivers/pinctrl/airoha/Kconfig b/drivers/pinctrl/airoha/Kconfig
>>> index eb87afbb374..986d23c2e3d 100644
>>> --- a/drivers/pinctrl/airoha/Kconfig
>>> +++ b/drivers/pinctrl/airoha/Kconfig
>>> @@ -9,3 +9,8 @@ config PINCTRL_AIROHA
>>> select REGMAP
>>> select SYSCON
>>> bool
>>> +
>>> +config PINCTRL_AIROHA_AN7581
>>> + tristate "AN7581 pin controller and gpio driver"
>>> + depends on TARGET_AN7581
>>> + select PINCTRL_AIROHA
>>> diff --git a/drivers/pinctrl/airoha/Makefile
>>> b/drivers/pinctrl/airoha/Makefile
>>> index a25b744dd7a..909bd9a04d9 100644
>>> --- a/drivers/pinctrl/airoha/Makefile
>>> +++ b/drivers/pinctrl/airoha/Makefile
>>> @@ -1,3 +1,5 @@
>>> # SPDX-License-Identifier: GPL-2.0
>>>
>>> obj-$(CONFIG_PINCTRL_AIROHA) += pinctrl-airoha.o
>>> +
>>> +obj-$(CONFIG_PINCTRL_AIROHA_AN7581) += pinctrl-an7581.o
>>> diff --git a/drivers/pinctrl/airoha/pinctrl-an7581.c
>>> b/drivers/pinctrl/airoha/pinctrl-an7581.c
>>> new file mode 100644
>>> index 00000000000..2505818251c
>>> --- /dev/null
>>> +++ b/drivers/pinctrl/airoha/pinctrl-an7581.c
>>> @@ -0,0 +1,1074 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Author: Lorenzo Bianconi <[email protected]>
>>> + * Author: Benjamin Larsson <[email protected]>
>>> + * Author: Markus Gothe <[email protected]>
>>> + */
>>> +#include "airoha-common.h"
>>> +
>> The en7581_ prefix doesn't match the file name or Kconfig. Did you
>> mean to use an7581_ everywhere?
> Good question. EN7581 is the initial name of the chip. The rename to
> AN7581 was caused by renaming of Econet company to Airoha. There are a
> lot of places where en7581_ prefix is used. Also this prefix used in the
> original linux driver, so I prefer to keep it as is.
>>
Then why not also change the file name, etc. to match? Otherwise, it just
looks like a typo if you don't know the history.
