Hi,
> 
> Add GigaDevice GD55LB02GF (256 MiB, JEDEC 0xc8 0x60 0x1c) to the
> spi-nor ID table.
> 
> Same die family as the existing gd55lb02g entry but a distinct memtype
> byte (0x60 versus 0x67), so the existing entry does not match.
> 
0xc8671c is for GD55LB02GE and there is duplicate entry appears in the last
part of GigaDevice entries. Besides SPI_NOR_HAS_TB flag is missing in the
"gd55lb02g" entry...

> Signed-off-by: Vincent Jardin <[email protected]>
> 
> ---
> 
>  drivers/mtd/spi/spi-nor-ids.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index c0fa98424aa..50f6dd3e5c4 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -191,6 +191,8 @@ const struct flash_info spi_nor_ids[] = {
>         SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},
>         {INFO("gd55lb02g", 0xc8671C, 0, 64 * 1024, 4096,        SECT_4K |
>         SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},
> +       {INFO("gd55lb02gf", 0xc8601C, 0, 64 * 1024, 4096,       SECT_4K |
> +       SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},

Could you create a new entry just after "gd55lb02ge" with the same flags with
it? GD55LB02G'F' should be a successor chip of GD55LB02G'E'.

Thanks,
Takahiro

>         {INFO("gd25lf80", 0xc86314, 0, 64 * 1024, 16,   SECT_4K |
>         SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK)},
>         {INFO("gd25lf16", 0xc86315, 0, 64 * 1024, 32,   SECT_4K |
> --
> 2.43.0
> 
> base-commit: bfe90a308a94caa9d855440683521ff04122ae2a
> branch: for-upstream/spi-nor-gd55lb02gf

Reply via email to