Hi James,

On Mon, 2026-05-11 at 12:20 -0600, James Hilliard wrote:
> Environment callbacks can already be configured from Kconfig with
> CONFIG_ENV_CALLBACK_LIST_STATIC, but static environment flags still
> require board headers to define CFG_ENV_FLAGS_LIST_STATIC.
> 
> Add CONFIG_ENV_FLAGS_LIST_STATIC and use it as the only board-provided
> static environment flags list. Convert the remaining default-config users
> from CFG_ENV_FLAGS_LIST_STATIC to defconfig settings and drop the legacy
> header macro from ENV_FLAGS_LIST_STATIC.
> 
> Move the environment flags format documentation out of README and into
> the developer environment documentation. Include the format in the
> Kconfig help as well.
> 
> This lets boards configure writeable-list policy and type validation
> from defconfig without adding a config header solely for env flags.
> 
> This preserves the behavior of default configs. Header-only cases that
> were inactive in upstream defconfigs are not converted into defconfig
> entries: iot2050 can add its list when enabling ENV_WRITEABLE_LIST, and
> smegw01 can add mmcdev:dw support if the unlocked SYS_BOOT_LOCKED=n
> configuration is needed.
> 
> Signed-off-by: James Hilliard <[email protected]>
> Reviewed-by: Tom Rini <[email protected]>
> Reviewed-by: Simon Glass <[email protected]>

LGTM

Reviewed-by: Alexander Sverdlin <[email protected]>

> ---
> Changes v2 -> v3:
>   - Note that inactive header-only iot2050 flags and the smegw01
>     SYS_BOOT_LOCKED=n mmcdev:dw flag are not converted into defconfigs.
> 
> Changes v1 -> v2:
>   - Convert existing CFG_ENV_FLAGS_LIST_STATIC users to
>     CONFIG_ENV_FLAGS_LIST_STATIC in defconfigs.
>   - Drop CFG_ENV_FLAGS_LIST_STATIC support instead of appending the new
>     Kconfig value after the legacy C macro.
>   - Remove the trailing-comma requirement for board-specific static flags.
>   - Place the migrated defconfig entries in savedefconfig order.
>   - Move environment flags documentation from README to
>     doc/develop/environment.rst.
>   - Add the flags-list format to the CONFIG_ENV_FLAGS_LIST_STATIC Kconfig
>     help text.
> ---
>  README                               | 45 +---------------------------
>  configs/aristainetos2c_defconfig     |  1 +
>  configs/aristainetos2ccslb_defconfig |  1 +
>  configs/hmibsc_defconfig             |  1 +
>  configs/imx6q_bosch_acc_defconfig    |  1 +
>  configs/imx8qxp_capricorn.config     |  1 +
>  configs/smegw01_defconfig            |  1 +
>  configs/socrates_defconfig           |  1 +
>  doc/develop/environment.rst          | 40 +++++++++++++++++++++++++
>  env/Kconfig                          | 23 ++++++++++++++
>  include/configs/aristainetos2.h      |  3 --
>  include/configs/capricorn-common.h   | 13 --------
>  include/configs/hmibsc.h             |  4 ---
>  include/configs/imx6q-bosch-acc.h    | 12 --------
>  include/configs/iot2050.h            |  8 -----
>  include/configs/smegw01.h            | 15 ----------
>  include/configs/socrates.h           |  2 --
>  include/env_flags.h                  |  6 +---
>  18 files changed, 72 insertions(+), 106 deletions(-)

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

Reply via email to