On Mon, May 18, 2026 at 02:58:53PM -0600, Tom Rini wrote: > On Mon, May 18, 2026 at 10:25:05PM +0200, Michael Srba wrote: > > Hi, > > > > On 5/18/26 10:40, Casey Connolly wrote: > > > Hi Michael, > > > > > > On 16/05/2026 20:19, [email protected] wrote: > > > > From: Michael Srba <[email protected]> > > > > > > > > Select SUPPORT_SPL so SPL build can be enabled, disable SYSRESET_PSCI > > > > in SPL. > > > > (SPL runs in EL3, so if SPL itself doesn't provide PSCI, nothing else > > > > will.) > > > > > > > > Also select (SPL_)OF_LIVE and DM_EVENT/SPL_EVENT, which are needed to > > > > fix up > > > > upstream dt to make usb work. > > > > > > > > Mirror u-boot proper selections like GPIO and pinctrl to ensure > > > > consistent > > > > behavior, and select SPL_SPRINTF, SPL_LIBCOMMON_SUPPORT etc for similar > > > > reasons. > > > > > > > > Signed-off-by: Michael Srba <[email protected]> > > > > Reviewed-by: Simon Glass <[email protected]> > > > > --- > > > > arch/arm/Kconfig | 33 > > > > ++++++++++++++++++++++++++++++++- > > > > arch/arm/mach-snapdragon/Kconfig | 10 ++++++++++ > > > > 2 files changed, 42 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > > index 850768282ce..255d2035cdc 100644 > > > > --- a/arch/arm/Kconfig > > > > +++ b/arch/arm/Kconfig > > > > @@ -1136,6 +1136,7 @@ config ARCH_SNAPDRAGON > > > > bool "Qualcomm Snapdragon SoCs" > > > > select ARM64 > > > > select DM > > > > + select DM_EVENT if USB_DWC3_GENERIC > > > Is there any reason not to make this uncoditional? > > Well, my understanding is that it's only relevant if something registers > > to receive an event. Maybe some stuff just has a slower path but would > > benefit from this? I don't know, all I know is that the fixup has a hard > > dependency on it. > > This seems like a USB_DWC3_GENERIC bug (missing select DM_EVENT), but > not something you need to tackle as this is just following the existing > way.
Following up to myself, it's not a USB_DWC3_GENERIC bug, it's a more generic bug somewhere. I think the best answer here is to just "select DM_EVENT" which is what a number of other SoCs do, and I'll go dig in to what is missing a select DM_EVENT. -- Tom
signature.asc
Description: PGP signature
