On Sun, May 24, 2026 at 07:22:54PM +0200, Marek Vasut wrote: > Boot from FSPI requires additional 448 Byte long header, with U-Boot SPL > starting at offset 0x1000. Currently, both i.MX8MM and i.MX8MN attempt > to generate this header using fspi_conf_block with filename pointing at > CONFIG_FSPI_CONF_FILE file. This does not work, for two reasons. > > First, the CONFIG_FSPI_CONF_FILE is generated by mkimage -T imx8mimage > and may not be available yet when the fspi_conf_block is evaluated. That > leads to a race condition where highly parallel builds fail to find the > CONFIG_FSPI_CONF_FILE, which is usually called fspi_header.bin, on first > build attempt. > > Second, binman gets confused and patches incorrect offset of DDR PHY > firmware blobs into U-Boot SPL, the offset is incremented by exactly > 0x1000 which is the size of fspi_conf_block. > > Fix both problems at once, make imx8mimage handle the generated FSPI > header and prepend it in front of the imx8mimage processed data. This > way, the race condition is solved, because the data generated by the > imx8mimage are surely combined only after mkimage -T imx8mimage ran. > The binman offset calculation is also solved, because there is no > fspi_conf_block node in the DT anymore. > > Signed-off-by: Marek Vasut <[email protected]> > --- > Cc: "NXP i.MX U-Boot Team" <[email protected]> > Cc: Adam Ford <[email protected]> > Cc: Alexander Koch <[email protected]> > Cc: Fabio Estevam <[email protected]> > Cc: Peng Fan <[email protected]> > Cc: Simon Glass <[email protected]> > Cc: Tom Rini <[email protected]> > Cc: [email protected] > --- > tools/binman/etype/nxp_imx8mimage.py | 8 +++++++- > tools/binman/ftest.py | 5 +++++ > tools/binman/test/351_nxp_imx8m_fspi.dts | 18 ++++++++++++++++++
Tests finally have subdirectories instead of the frequently conflicting numerical prefix, please pick a subdirectory of tools/binman/test/ for this for v2, and include a short cover letter as well, thanks! -- Tom
signature.asc
Description: PGP signature
