Hi Anton, On 2026-05-21T19:13:59, Anton Moryakov <[email protected]> wrote: > tools: ifwitool: fix memory leak in ibbp_dir_add() > > Signed-off-by: Anton Moryakov <[email protected]> > > tools/ifwitool.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass <[email protected]> > > tools: ifwitool: fix memory leak in ibbp_dir_add() > > Signed-off-by: Anton Moryakov <[email protected]> Please can you add a commit body? Describe which buffers leak on which path, and how you checked (static analysis, valgrind, etc). Something like: On the error path from buffer_from_file() the manifest buffer allocated above is never released. On the success path the manifest, ibbl and ibb buffers are copied into the destination subpart buffer by create_subpart() but never freed. Free them explicitly to plug the leak. Regards, Simon
