On Mon, May 25, 2026 at 09:25:13AM -0600, Simon Glass wrote: > Hi Denis, > > On 2026-05-22T01:23:09, None <[email protected]> wrote: > > > Patch 1 allows per-board default reset override. > > Patch 2 adds reset -c support to explicitly trigger cold reset. > > Patch 3 adds reset type printout on the console. > > Patch 4 introduces a small fixup for the x86 reset driver. > > Since you are adding new behaviour, I would expect a sandbox test to > go with it. The sysreset sandbox driver should make this > straightforward - what do you think?
Will add tests, thanks! > > Also, prefer board_sysreset_default() only as a last resort - could > this be a DT property on the sysreset device, or a uclass-platdata > field, or a syscon driver, so it doesn't need a board hook, or even in > extremis an event? Weak functions are awkward to discover and don't > compose well. I think to cover our peculiar board, Kconfig option should be the cleanest way to parameterize the build. > > Regards, > Simon
