> On 26.05.26 16:58, Francois Berder wrote: > dev_read_addr returns FDT_ADDR_T_NONE (-1), not NULL, in case of errors. > Replace dev_read_addr by dev_read_addr_ptr. > Replace error to EINVAL. > > Signed-off-by: Francois Berder <[email protected]> > --- > drivers/rng/jh7110_rng.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rng/jh7110_rng.c b/drivers/rng/jh7110_rng.c index > eb21afe4e7c..d54898c67f6 100644 > --- a/drivers/rng/jh7110_rng.c > +++ b/drivers/rng/jh7110_rng.c > @@ -233,9 +233,9 @@ static int starfive_trng_of_to_plat(struct udevice *dev) > { > struct starfive_trng_plat *pdata = dev_get_plat(dev); > > - pdata->base = (void *)dev_read_addr(dev); > + pdata->base = dev_read_addr_ptr(dev); > if (!pdata->base) > - return -ENODEV; > + return -EINVAL; > > pdata->hclk = devm_clk_get(dev, "hclk"); > if (IS_ERR(pdata->hclk))
Looks good. Reviewed-by: Hal Feng <[email protected]> Best regards, Hal
