Hi Denis, On 2026-05-29T03:44:35, None <[email protected]> wrote:
> Patch 4 enables flush for the currently selected block device. It adds the flush subcommand to all the block-uclass front-end commands (ide, nvme, pvblock, sata, scsi, usb, virtio) in one go. Please reword. > The series adds few fixes for NVMe subsystem. This is more than NVMe fixes - patch 2 adds a new block-uclass op and patch 4 touches seven command files. Since you are adding a new uclass operation, please add a test for blk_flush()/blk_dflush() under test/dm/blk.c covering success and -ENOSYS when .flush is absent. > Patch 5 makes nvme_shutdown() symbol public to enable use of it from > board_quiesce_devices() Really we should mark the driver as DM_FLAG_ACTIVE_DMA and then this happens automatically. The board_quiesce_devices() function should go away at some point. Regards, Simon
