On 5/21/26 9:20 AM, Yann Gautier wrote:
On 5/20/26 18:38, Marek Vasut wrote:
On 5/20/26 6:07 PM, Yann Gautier wrote:
This series adds the supports for Arm SMC watchdog for STM32MP1x
platforms. This enables the required config flags for both STM32MP13
and STM32MP15, and updates the U-Boot overlay DT file for STM32MP15
in SCMI configuration.

This series also requires a patch from Patrice[1] increasing the
CONFIG_SYS_MALLOC_F_LEN for STM32MP15.

[1]: https://patchwork.ozlabs.org/project/uboot/patch/20260518- master- [email protected]/

I hate to nitpick at this point, but, it seems the two patches in this series do effectively the same thing.

Not really, the watchdog config was already there for STM32MP15, and we now enable and use the Arm SMC watchdog.
For STM32MP13, no watchdog was configured at all in U-Boot.
So for me the patches titles make sense as they are.

Sorry, was busy with too many other emails.

1/3 and 2/3 does the same thing, enable CONFIG_WDT_ARM_SMC, the commit messages should be aligned. Do you even need CONFIG_WDT=y in 2/3 ?

I'd say, align the commit subjects to something like:

configs: stm32mp15: Enable Arm SMC watchdog

And:

configs: stm32mp13: Enable Arm SMC watchdog

Even the commit messages can likely be aligned ?

I'll check if I can improve that.
Please do.

Reply via email to