Hi Philippe, On Thu, May 28, 2026 at 4:19 AM Philippe Reynes <[email protected]> wrote: > > When initializing info about a signature, set required_keynode > to -1 instead of 0, as 0 is a valid keynode offset. > > Reviewed-by: Simon Glass <[email protected]> > Signed-off-by: Philippe Reynes <[email protected]> > --- > v5: > - initial version > v6: > - no change > v7: > - change info->required_keynode > 0 to info->required_keynode >= 0 > in ecdsa_verify_hash > > lib/ecdsa/ecdsa-verify.c | 2 +- > tools/image-host.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) >
Reviewed-by: Raymond Mao <[email protected]> Thanks and regards, Raymond > diff --git a/lib/ecdsa/ecdsa-verify.c b/lib/ecdsa/ecdsa-verify.c > index e58b8892b98..22279a7cc84 100644 > --- a/lib/ecdsa/ecdsa-verify.c > +++ b/lib/ecdsa/ecdsa-verify.c > @@ -111,7 +111,7 @@ static int ecdsa_verify_hash(struct udevice *dev, > if (!ops || !ops->verify) > return -ENODEV; > > - if (info->required_keynode > 0) { > + if (info->required_keynode >= 0) { > ret = fdt_get_key(&key, info->fdt_blob, > info->required_keynode); > if (ret < 0) > return ret; > diff --git a/tools/image-host.c b/tools/image-host.c > index 8b550af0dc1..f5681d6c1f9 100644 > --- a/tools/image-host.c > +++ b/tools/image-host.c > @@ -198,6 +198,7 @@ static int fit_image_setup_sig(struct image_sign_info > *info, > info->checksum = image_get_checksum_algo(algo_name); > info->crypto = image_get_crypto_algo(algo_name); > info->padding = image_get_padding_algo(padding_name); > + info->required_keynode = -1; > info->require_keys = require_keys; > info->engine_id = engine_id; > if (!info->checksum || !info->crypto) { > -- > 2.43.0 >
