Hi Peng, On 2026-06-02T11:21:39, Peng Fan (OSS) <[email protected]> wrote: > usb: musb-new: Use ofnode and dev APIs > > Convert the TI MUSB driver from legacy FDT interfaces to ofnode and dev > APIs to support both live device tree and flat DT backends. > > In ti_musb_get_usb_index(), replace fdt_get_path()/fdt_get_alias() > based string comparison with ofnode_get_aliases_node()/ofnode_equal() > to match USB alias by ofnode identity rather than path strings. > > In ti_musb_of_to_plat(), replace devfdt_get_addr_index_ptr() with > dev_read_addr_index_ptr() and add a NULL check on the result. Convert > four fdtdec_get_int() calls reading 'mentor,multipoint', 'mentor,num-eps', > 'mentor,ram-bits', and 'mentor,power' properties to dev_read_s32_default(). > > Remove DECLARE_GLOBAL_DATA_PTR and the asm/global_data.h include as > gd->fdt_blob is no longer referenced. > > Signed-off-by: Peng Fan <[email protected]> > > drivers/usb/musb-new/ti-musb.c | 34 ++++++++++++++-------------------- > 1 file changed, 14 insertions(+), 20 deletions(-)
Reviewed-by: Simon Glass <[email protected]> nit below > diff --git a/drivers/usb/musb-new/ti-musb.c b/drivers/usb/musb-new/ti-musb.c > @@ -51,29 +48,25 @@ static void ti_musb_set_phy_power(struct udevice *dev, u8 > on) > i++; > - } while (alias_path); > + } while (1); > > return -ENOENT; > } The trailing return -ENOENT is now unreachable. Please drop it, or restructure as for (i = 0; ; i++) so the intent is clearer. Some toolchains warn on unreachable code. Regards, Simon
