On 2026-06-01T06:05:33, Sam Day <[email protected]> wrote: > video: simplefb: fix rot prop handling > > If the simplefb node lacks a rot property (which would be most of them > nowadays - it's not actually a valid prop according to kernel's > simple-framebuffer schema), then the rot local is left uninitialized. > This causes video_post_probe to fail to locate the vidconsoleN device > later. > > Strangely enough, simplefb has been working fine on arm64 targets. It > wasn't until I tried simplefb on my arm32 device (samsung-expressltexx) > that this issue manifested. AFAICT, ARM64 doesn't have something like > -ftrivial-auto-var-init=zero enabled, so I suspect this has just been > working entirely by coincidence until now. Computers are fun. > > Fixes: 91e9687b49e7 ("video: simplefb: modernise DT parsing") > Signed-off-by: Sam Day <[email protected]> > Reviewed-by: Casey Connolly <[email protected]> > > drivers/video/simplefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <[email protected]>
