On 6/11/26 20:13, Ilias Apalodimas wrote:
On Thu, 11 Jun 2026 at 19:21, Ludwig Nussel <[email protected]> wrote:
On 6/11/26 11:57, Ilias Apalodimas wrote:
The CI [0] fails with this attached. You can run it in github by
opening a PR before v3. Also can you update the description and add
the use case you mention in the cover letter?
Done. The hardware tests are still pending but I've fixed the qemu
failures: [...]
Is it advisable to file a pr in general before submitting patches?
Yea, it makes reviewers life easier. I will run the CI regardless, but
it saves new versions just because the CI failed.
Ok. It also makes my life as contributor easier as I don't want to
bother human reviewers with issues the machine can find.
That being said, I had a lot more feedback in v2 than the one that you
just fixed in v3. Have a look at the comments and let me know if you
need anything else
Hmm, indeed. Sorry for that. I'm not sure how I managed to miss them.
Will take a look.
cu
Ludwig
--
Ludwig Nussel
Siemens AG
www.siemens.com
