Hi Denis, On 2026-06-05T03:38:59, None <[email protected]> wrote: > bootcount: gpt: ensure coreboot payload enables DM_BOOTCOUNT > > Ensure that bootcount-gpt device is enabled in U-Boot when running > as a coreboot payload. > > Signed-off-by: Denis Mukhin <[email protected]> > > drivers/bootcount/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig > @@ -13,7 +13,8 @@ if BOOTCOUNT_LIMIT > choice > prompt "Boot count device" > default BOOTCOUNT_AM33XX if AM33XX || SOC_DA8XX > - default BOOTCOUNT_GENERIC > + default BOOTCOUNT_GENERIC if !VENDOR_COREBOOT > + default DM_BOOTCOUNT if VENDOR_COREBOOT The subject says 'ensure bootcount-gpt is enabled' but this hunk selects DM_BOOTCOUNT, the generic DM choice - not DM_BOOTCOUNT_GPT. Please reconcile the two and spell out in the message what actually happens...the user still has to turn on DM_BOOTCOUNT_GPT under the DM_BOOTCOUNT menu. The motivation is also missing. Why should every VENDOR_COREBOOT build silently switch its default from BOOTCOUNT_GENERIC to DM_BOOTCOUNT? Coreboot runs on many platforms with no GPT disk and no use for a DM bootcount, and changing a choice default will move existing configs on the next defconfig refresh. That seems heavy-handed for what is really 'a Ford/Chromium platform wants GPT bootcount' - wouldn't it be cleaner to set this in the relevant board defconfig rather than taking over the global default for all coreboot payloads? What do you think? Regards, Simon
