Hi Simon, On Thu, Jun 18, 2026 at 16:12, Simon Glass <[email protected]> wrote:
> Hi Mattijs, > > On Mon, 8 Jun 2026 at 09:53, Mattijs Korpershoek > <[email protected]> wrote: >> >> Hi Simon, >> >> Thank you for the series. >> >> On Sat, May 23, 2026 at 02:54, Simon Glass <[email protected]> wrote: >> >> > test_ut.py has accumulated a setup_*_image() helper for each image that >> > the bootflow tests want to boot. Each one is mostly shell script and >> > partition layout, so the file is large and the test logic is hidden >> > among image-creation details. >> > >> > Move each setup function to its own module under test/py/img/, with a >> > shared common.py for mkdir_cond(), copy_partition() and the >> > make_extlinux_disk() helper. Each patch moves one image at a time so >> > reviewers can see the relocation cleanly. The modules are named after >> > the bootmeth or feature they exercise rather than the distribution they >> > are modelled on. >> > >> > While here, also redirect the generated disk images to the >> > persistent-data directory instead of writing them under the source >> > tree. The sandbox mmc, scsi and usb-flash drivers now look there first. >> > >> > Further improvements are planned, such as using the context manager >> > when creating partitions. >> >> I've tested this on sandbox using: >> >> $ ./test/py/test.py --bd sandbox --build -k ut >> $ ./test/py/test.py --bd sandbox --build -k bootflow_android >> >> Tested-by: Mattijs Korpershoek <[email protected]> > > I appreciate you reviewing this - quite tedious work! Happy to help :) Please also see the individual commits for review remarks. I've found a couple of things I had questions on. Regards, Mattijs > > Regards, > Simon
